On Wed, 2014-03-19 at 13:57 +0530, Sachin Kamat wrote: > On 18 March 2014 18:41, Krzysztof Kozlowski <k.kozlow...@samsung.com> wrote: > > Initialize the 'regmap_rtc' on S2MPA01 to some sane value. Sane at least > > for S5M87X chipsets, not S2MPS/S2MPA but it won't be used because > > rtc-s5m driver does not support S2MPA01. > > > > This fixes following error: > > drivers/mfd/sec-core.c:342:45: warning: 'regmap_rtc' may be used > > uninitialized in this function [-Wuninitialized] > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> > > From the point of suppressing this warning and considering how it is > done for S2MPS11, > Acked-by: Sachin Kamat <sachin.ka...@linaro.org> > > However, shouldn't we be making this RTC handling conditional/optional > depending upon > whether the h/w or s/w supports/implements it?
I think the rtc-s5m driver should instantiate his regmap on its own. The same with i2c dummy device. This would remove problems with unsupported chipsets by rtc-s5m driver. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
