* Prarit Bhargava <pra...@redhat.com> wrote:

> fixup_irqs() calls chip->set_irq_affinity which eventually calls
> __assign_irq_vector().  Errors are not propogated back from this function call
> and this results in silent irq relocation failures.  This patch fixes this
> issue and prints out a warning if there is a relocation failure.
> 
> [v2]: modified WARN to pr_crit and changed message

Please fix the changelog to conform to the standard changelog style:

 - first describe the symptoms of the bug - how does a user notice? 

 - then describe how the code behaves today and how that is causing the bug

 - and then only describe how it's fixed.

The first item is the most important one - yet it's missing from this 
changelog.

Thanks,

        Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to