Hi Geert, Thank you for the patches.
I had patches similar to 3/4 and 4/4 in my tree, that's a sign you're going in the right direction (or at least the direction I consider to be right :-)). For the whole series, Acked-by: Laurent Pinchart <[email protected]> On Tuesday 11 March 2014 11:11:17 Geert Uytterhoeven wrote: > From: Geert Uytterhoeven <[email protected]> > > Make banner const while we're at it > > Signed-off-by: Geert Uytterhoeven <[email protected]> > --- > drivers/tty/serial/sh-sci.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c > index 7958115e6a51..24ec6ef67984 100644 > --- a/drivers/tty/serial/sh-sci.c > +++ b/drivers/tty/serial/sh-sci.c > @@ -428,7 +428,7 @@ static int sci_probe_regmap(struct plat_sci_port *cfg) > cfg->regtype = SCIx_HSCIF_REGTYPE; > break; > default: > - printk(KERN_ERR "Can't probe register map for given port\n"); > + pr_err("Can't probe register map for given port\n"); > return -EINVAL; > } > > @@ -2389,8 +2389,7 @@ static inline int sci_probe_earlyprintk(struct > platform_device *pdev) > > #endif /* CONFIG_SERIAL_SH_SCI_CONSOLE */ > > -static char banner[] __initdata = > - KERN_INFO "SuperH (H)SCI(F) driver initialized\n"; > +static const char banner[] __initconst = "SuperH (H)SCI(F) driver > initialized"; > > static struct uart_driver sci_uart_driver = { > .owner = THIS_MODULE, > @@ -2616,7 +2615,7 @@ static int __init sci_init(void) > { > int ret; > > - printk(banner); > + pr_info("%s\n", banner); > > ret = uart_register_driver(&sci_uart_driver); > if (likely(ret == 0)) { -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
