On 03/08/2014 07:46 PM, Chao Yu wrote: > Hi Gu, > >> -----Original Message----- >> From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com] >> Sent: Friday, March 07, 2014 6:43 PM >> To: Kim >> Cc: linux-kernel; f2fs >> Subject: [f2fs-dev] [PATCH 1/5] f2fs: update start nid only once each circle >> >> >> Signed-off-by: Gu Zheng <guz.f...@cn.fujitsu.com> > > Reviewed-by: Chao Yu <chao2...@samsung.com> > >> --- >> fs/f2fs/node.c | 6 +++++- >> 1 files changed, 5 insertions(+), 1 deletions(-) >> >> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c >> index 8c14110..9653096 100644 >> --- a/fs/f2fs/node.c >> +++ b/fs/f2fs/node.c >> @@ -1875,11 +1875,15 @@ void destroy_node_manager(struct f2fs_sb_info *sbi) >> while ((found = __gang_lookup_nat_cache(nm_i, >> nid, NATVEC_SIZE, natvec))) { >> unsigned idx; >> + >> + nid = nat_get_nid(natvec[found - 1]) + 1; >> + >> for (idx = 0; idx < found; idx++) { >> struct nat_entry *e = natvec[idx]; > > Could we replace argument 'e' with 'natvec[idx]'? then we could remove 'e' and > brace here.
Agree. More neat with this cleanup. Regards, Gu > > Thanks. > >> - nid = nat_get_nid(e) + 1; >> + >> __del_from_nat_cache(nm_i, e); >> } >> + >> } >> f2fs_bug_on(nm_i->nat_cnt); >> write_unlock(&nm_i->nat_tree_lock); >> -- >> 1.7.7 >> >> >> ------------------------------------------------------------------------------ >> Subversion Kills Productivity. Get off Subversion & Make the Move to >> Perforce. >> With Perforce, you get hassle-free workflows. Merge that actually works. >> Faster operations. Version large binaries. Built-in WAN optimization and the >> freedom to use Git, Perforce or both. Make the move to Perforce. >> http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk >> _______________________________________________ >> Linux-f2fs-devel mailing list >> linux-f2fs-de...@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
