On Sun, 2014-03-09 at 11:57 -0700, Alexei Starovoitov wrote:

> In sk_run_filter_ext() I used "u64 stack[64];", but "u64 stack[60];" is
> safe too, but I didn't want to go into extensive explanation
> of 'magic' 60 number in the first patch, so I just rounded it to 64.
> Since now you understand, I can make it stack[60] now :)

My point was : You should not use 64 or 60 in the C code.

I should not have to ask you why it is safe.

It should be obvious just reading the source code. And so far it is not.

Thats why we use macros and comments at the macro definition.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to