On Thu, 2014-03-06 at 11:52 -0800, beh...@converseincode.com wrote: > From: Jan-Simon Möller <dl...@gmx.de> > > Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99 > compliant equivalent.
Fine, but > + char aead_req_data[sizeof(struct aead_request) > + + crypto_aead_reqsize(tfm) > + + CRYPTO_MINALIGN] CRYPTO_MINALIGN_ATTR; You really should be using kernel coding style, which changes indentation and has the + on the previous line. > + struct aead_request *aead_req > + = (struct aead_request *) aead_req_data; (void *) is perfectly find and it'll probably fit on one line then. > + memset(&aead_req_data, 0, (sizeof(struct aead_request)+ > + crypto_aead_reqsize(tfm) + CRYPTO_MINALIGN)); You don't need the size calculation again, you can use sizeof(aead_req_data) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
