On Wed, 2014-03-05 at 17:27 -0500, Richard Guy Briggs wrote:
> On 14/03/05, Josh Boyer wrote:
> > Calling audit_log_lost with a \n in the format string leads to extra
> > newlines in dmesg. That function will eventually call audit_panic which
> > uses pr_err with an explicit \n included. Just make these calls match the
> > others that lack \n.
> >
> > Reported-by: Jonathan Kamens <[email protected]>
> > Signed-off-by: Josh Boyer <[email protected]>
>
> Ack. queued.
There's an unnecessary use of a \n in audit_panic too
---
kernel/auditsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 7aef2f4..da93d2e 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -1157,7 +1157,7 @@ static void audit_log_execve_info(struct audit_context
*context,
*/
buf = kmalloc(MAX_EXECVE_AUDIT_LEN + 1, GFP_KERNEL);
if (!buf) {
- audit_panic("out of memory for argv string\n");
+ audit_panic("out of memory for argv string");
return;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
