On Fri, 28 Feb 2014 21:46:21 +0100 Peter Zijlstra <pet...@infradead.org> wrote:
> NAK, spin_lock_irq() is very much an IRQ safe lock. Similarly Actually, that's not true. It doesn't mean it is an IRQ safe lock. That would mean it is safe to use in IRQs. What it does mean is that it disables irqs and spin_unlock_irq() enables irqs. And we have spin_lock_irqsave() which disables irqs and saves the flags for a spin_lock_irqrestore() > copy_from_user_nmi() is an NMI safe copy from user. > > Furthermore, there's exactly 0 trace users, so the proposed name is > actively worse. OK, I'll go with that. So instead of an _nmi() which it has nothing to do with NMIs, how about making it like spin_lock_irq() and a more descriptive name about what it does? copy_from_user_savecr2() ? -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
