On Thu, Feb 27, 2014 at 09:03:41AM +0000, Chew, Chiau Ee wrote:
> > > > +static int pwm_lpss_probe(struct platform_device *pdev) {
> > > > + struct device *dev = &pdev->dev;
> > > > + struct pwm_lpss_chip *lpwm;
> > > > + int ret;
> > > > +
> > > > + lpwm = dev_get_platdata(dev);
> > >
> > > struct pwm_lpss_chip is defined in this source file, how can anybody
> > > else know what to fill platform_data with?
> >
> > Good point. Chiau Ee, do you recall why that thing is there in the first
> > place?
>
> This is added because we would eventually want to have PCI enumeration support
> added. I think we shall find a way to better enable both the ACPI enumeration
> and
> PCI enumeration support.
Agreed. For now, can you please drop the platform data thing from the
driver? Thanks.
> > > > + if (!lpwm) {
> > > > + lpwm = pwm_lpss_acpi_get_pdata(pdev);
> > > > + if (!lpwm)
> > > > + return -ENODEV;
> > > > + }
> > > [...]
> > > > +static struct platform_driver pwm_lpss_driver = {
> > > > + .driver = {
> > > > + .name = "pwm-lpss",
> > > > + .acpi_match_table = ACPI_PTR(pwm_lpss_acpi_match),
> > >
> > > ACPI_PTR not needed since the table will always be there.
> >
> > OK.
> >
> > >
> > > > + },
> > > > + .probe = pwm_lpss_probe,
> > > > + .remove = pwm_lpss_remove,
> > > > +};
> > > > +module_platform_driver(pwm_lpss_driver);
> > > > +
> > > > +MODULE_DESCRIPTION("PWM driver for Intel LPSS");
> > > > +MODULE_AUTHOR("Mika Westerberg
> > <mika.westerb...@linux.intel.com>");
> > > > +MODULE_LICENSE("GPL");
> > >
> > > The file header says GPL v2, but "GPL" here means "GPL v2 or later".
> >
> > OK, we will change that to GPLv2.
> >
> > Thanks a lot for your review! We will do the changes and submit v2.
>
> Ok. I will make the changes accordingly.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
