From: Namhyung Kim <namhy...@kernel.org>

It seems there's no reason to prevent mixed used of ftrace and perf
for a single uprobe event.  At least the kprobes already support it.

Link: 
http://lkml.kernel.org/r/1389946120-19610-6-git-send-email-namhy...@kernel.org

Reviewed-by: Masami Hiramatsu <masami.hiramatsu...@hitachi.com>
Cc: Frederic Weisbecker <fweis...@gmail.com>
Cc: Ingo Molnar <mi...@kernel.org>
Cc: Oleg Nesterov <o...@redhat.com>
Cc: Srikar Dronamraju <sri...@linux.vnet.ibm.com>
Cc: zhangwei(Jovi) <jovi.zhang...@huawei.com>
Signed-off-by: Namhyung Kim <namhy...@kernel.org>
Signed-off-by: Steven Rostedt <rost...@goodmis.org>
---
 kernel/trace/trace_uprobe.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 01fcb0d..e447336 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -882,9 +882,6 @@ probe_event_enable(struct trace_uprobe *tu, struct 
ftrace_event_file *file,
        int ret;
 
        if (file) {
-               if (tu->tp.flags & TP_FLAG_PROFILE)
-                       return -EINTR;
-
                link = kmalloc(sizeof(*link), GFP_KERNEL);
                if (!link)
                        return -ENOMEM;
@@ -893,12 +890,8 @@ probe_event_enable(struct trace_uprobe *tu, struct 
ftrace_event_file *file,
                list_add_tail_rcu(&link->list, &tu->tp.files);
 
                tu->tp.flags |= TP_FLAG_TRACE;
-       } else {
-               if (tu->tp.flags & TP_FLAG_TRACE)
-                       return -EINTR;
-
+       } else
                tu->tp.flags |= TP_FLAG_PROFILE;
-       }
 
        ret = uprobe_buffer_enable();
        if (ret < 0)
-- 
1.8.5.3


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to