> -----Original Message-----
> From: Mark Brown [mailto:broo...@kernel.org]
> Sent: 19 February 2014 16:48
> To: Opensource [Anthony Olech]
> Cc: Liam Girdwood; Lee Jones; linux-kernel@vger.kernel.org; Samuel Ortiz;
> David Dajun Chen
> Subject: Re: [PATCH V1 3/3] REGULATOR: da9052: Add new DA9053 BC chip
> variant
> On Wed, Feb 19, 2014 at 04:32:47PM +0000, Opensource [Anthony Olech]
> wrote:
> > Add support for a new BC variant of the DA9053 PMIC.
> Acked-by: Mark Brown <broo...@linaro.org>
> > There is one difference between it and the AA, BA and BB.
> Which is...? :)
Hi Mark,
it is easier to see in the diff -C15 output, that the BC chip does not need
a 'safe read':
--- drivers/mfd/da9052-i2c.c Thu Feb 20 09:20:43 2014
***************
*** 63,92 ****
--- 63,93 ----
static int da9052_i2c_fix(struct da9052 *da9052, unsigned char reg)
{
int val;
switch (da9052->chip_id) {
case DA9052:
case DA9053_AA:
case DA9053_BA:
case DA9053_BB:
/* A dummy read to a safe register address. */
if (!i2c_safe_reg(reg))
return regmap_read(da9052->regmap,
DA9052_PARK_REGISTER,
&val);
break;
+ case DA9053_BC:
default:
/*
* For other chips parking of I2C register
* to a safe place is not required.
*/
break;
}
return 0;
}
Tony Olech
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
