On Mon, 2014-01-20 at 21:24 +0000, Zoltan Kiss wrote: > > + spinlock_t dealloc_lock; > + spinlock_t response_lock;
Please add comments to both of these describing what bits of the datastructure they are locking. You might find it is clearer to group the locks and the things they protect together rather than grouping the locks together. Ian. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/