On 07.02.14 04:15, Matthew Rushton wrote: > On 04/02/14 10:26, Roger Pau Monne wrote: >> I've at least identified two possible memory leaks in blkback, both >> related to the shutdown path of a VBD: >> >> - blkback doesn't wait for any pending purge work to finish before >> cleaning the list of free_pages. The purge work will call >> put_free_pages and thus we might end up with pages being added to >> the free_pages list after we have emptied it. Fix this by making >> sure there's no pending purge work before exiting >> xen_blkif_schedule, and moving the free_page cleanup code to >> xen_blkif_free. >> - blkback doesn't wait for pending requests to end before cleaning >> persistent grants and the list of free_pages. Again this can add >> pages to the free_pages list or persistent grants to the >> persistent_gnts red-black tree. Fixed by moving the persistent >> grants and free_pages cleanup code to xen_blkif_free. >> >> Also, add some checks in xen_blkif_free to make sure we are cleaning >> everything. > > Tested-by: Matt Rushton <[email protected]> > Reviewed-by: Matt Rushton <[email protected]>
Tested-by: Christoph Egger <[email protected]> Reviewed-by: Christoph Egger <[email protected]> Christoph -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
