On Wed, Jan 22, 2014 at 10:17:40PM +0100, Markus Trippelsdorf wrote:
> Yes. Thanks Peter.
>
Ah much simpler patch that should have the same effect:
---
Subject: sched/x86/tsc: Initialize multiplier to 0
From: Peter Zijlstra <pet...@infradead.org>
Date: Wed, 22 Jan 2014 22:08:14 +0100
Since we keep the clock value linearly continuous on frequency change,
make sure the initial multiplier is 0, such that out initial value is
0. Without this we compute the initial value at whatever the TSC has
managed to reach since power-on.
Fixes: 20d1c86a57762 ("sched/clock, x86: Rewrite cyc2ns() to avoid the need to
disable IRQs")
Cc: l...@kernel.org
Cc: r...@rjwysocki.net
Cc: Eliezer Tamir <eliezer.ta...@linux.intel.com>
Cc: rui.zh...@intel.com
Cc: jacob.jun....@linux.intel.com
Cc: Mike Galbraith <bitbuc...@online.de>
Cc: Ingo Molnar <mi...@kernel.org>
Cc: h...@zytor.com
Cc: paul...@linux.vnet.ibm.com
Cc: Thomas Gleixner <t...@linutronix.de>
Cc: John Stultz <john.stu...@linaro.org>
Cc: Andy Lutomirski <l...@amacapital.net>
Cc: Arjan van de Ven <ar...@linux.intel.com>
Cc: Sasha Levin <sasha.le...@oracle.com>
Cc: dyo...@redhat.com
Reported-by: Markus Trippelsdorf <mar...@trippelsdorf.de>
Signed-off-by: Peter Zijlstra <pet...@infradead.org>
---
arch/x86/kernel/tsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -180,7 +180,7 @@ static void cyc2ns_write_end(int cpu, st
static void cyc2ns_data_init(struct cyc2ns_data *data)
{
- data->cyc2ns_mul = 1U << CYC2NS_SCALE_FACTOR;
+ data->cyc2ns_mul = 0;
data->cyc2ns_shift = CYC2NS_SCALE_FACTOR;
data->cyc2ns_offset = 0;
data->__count = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
