Hi all, On Tue, 21 Jan 2014 10:11:39 -0800 Linus Torvalds <torva...@linux-foundation.org> wrote: > > On Tue, Jan 21, 2014 at 12:36 AM, Linus Walleij > <linus.wall...@linaro.org> wrote: > > > > here is the big GPIO pull request for the v3.14 series. > > Ugh. It does not compile for me. The problem seems to be that the > gpio-mcp23s08.c driver only compiles in OF environments, but isn't > properly restricted to them: > > drivers/gpio/gpio-mcp23s08.c: In function ‘mcp23s08_irq_setup’: > drivers/gpio/gpio-mcp23s08.c:482:46: error: ‘struct gpio_chip’ has > no member named ‘of_node’ > mcp->irq_domain = irq_domain_add_linear(chip->of_node, chip->ngpio, > > and similar other errors.
Yep, reported when it entered linux-next.
> Introduced by commit 4e47f91bf741 ("gpio: mcp23s08: Add irq
> functionality for i2c chips") as far as I can tell.
>
> > It's big this time but has been brewing in linux-next for
> > some time and it's all good stuff IMO
>
> The fact that it doesn't even compile makes me doubt your statement
> that it has been in linux-next. It doesn't even pass a basic
> allmodconfig build.
That particular commit was reverted in linux-next when it first turned up
on Monday and again yesterday.
--
Cheers,
Stephen Rothwell s...@canb.auug.org.au
pgpJikdnG7ro_.pgp
Description: PGP signature
