On 01/20/2014 11:52 AM, Peter Zijlstra wrote:
> On Fri, Jan 17, 2014 at 04:12:06PM -0500, r...@redhat.com wrote:
>> +++ b/kernel/sched/fair.c
>> @@ -1300,10 +1300,14 @@ static void update_numa_active_node_mask(struct
>> task_struct *p)
>> faults = numa_group->faults_from[task_faults_idx(nid, 0)] +
>> numa_group->faults_from[task_faults_idx(nid, 1)];
>> if (!node_isset(nid, numa_group->active_nodes)) {
>> - if (faults > max_faults * 4 / 10)
>> + if (faults > max_faults * 4 / 10) {
>> +
>> trace_update_numa_active_nodes_mask(current->pid, numa_group->gid, nid,
>> true, faults, max_faults);
>
> While I think the tracepoint hookery is smart enough to avoid evaluating
> arguments when they're disabled, it might be best to simply pass:
> current and numa_group and do the dereference in fast_assign().
>
> That said, this is the first and only numa tracepoint, I'm not sure why
> this qualifies and other metrics do not.
It's there because I needed it in development.
If you think it is not merge material, I would be comfortable
leaving it out.
--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
