[PATCH 6/7] pktgen: Use ether_addr_copy

[Joe Perches]

Use ether_addr_copy instead of memcpy(a, b, ETH_ALEN) to
save some cycles on arm and powerpc.

Signed-off-by: Joe Perches <j...@perches.com>
---
 net/core/pktgen.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index fa3e128..fdac61c 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -1440,7 +1440,7 @@ static ssize_t pktgen_if_write(struct file *file,
                if (!mac_pton(valstr, pkt_dev->dst_mac))
                        return -EINVAL;
                /* Set up Dest MAC */
-               memcpy(&pkt_dev->hh[0], pkt_dev->dst_mac, ETH_ALEN);
+               ether_addr_copy(&pkt_dev->hh[0], pkt_dev->dst_mac);
 
                sprintf(pg_result, "OK: dstmac %pM", pkt_dev->dst_mac);
                return count;
@@ -1457,7 +1457,7 @@ static ssize_t pktgen_if_write(struct file *file,
                if (!mac_pton(valstr, pkt_dev->src_mac))
                        return -EINVAL;
                /* Set up Src MAC */
-               memcpy(&pkt_dev->hh[6], pkt_dev->src_mac, ETH_ALEN);
+               ether_addr_copy(&pkt_dev->hh[6], pkt_dev->src_mac);
 
                sprintf(pg_result, "OK: srcmac %pM", pkt_dev->src_mac);
                return count;
@@ -2060,10 +2060,10 @@ static void pktgen_setup_inject(struct pktgen_dev 
*pkt_dev)
        /* Default to the interface's mac if not explicitly set. */
 
        if (is_zero_ether_addr(pkt_dev->src_mac))
-               memcpy(&(pkt_dev->hh[6]), pkt_dev->odev->dev_addr, ETH_ALEN);
+               ether_addr_copy(&(pkt_dev->hh[6]), pkt_dev->odev->dev_addr);
 
        /* Set up Dest MAC */
-       memcpy(&(pkt_dev->hh[0]), pkt_dev->dst_mac, ETH_ALEN);
+       ether_addr_copy(&(pkt_dev->hh[0]), pkt_dev->dst_mac);
 
        if (pkt_dev->flags & F_IPV6) {
                int i, set = 0, err = 1;
-- 
1.8.1.2.459.gbcd45b4.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/