Hi, Le lundi 13 janvier 2014 à 10:30 +0100, Yann Droneaud a écrit : > Le lundi 13 janvier 2014 à 10:06 +1100, Benjamin Herrenschmidt a écrit : > > On Tue, 2013-07-02 at 18:39 +0200, Yann Droneaud wrote: > > > Macro get_unused_fd() is used to allocate a file descriptor with > > > default flags. Those default flags (0) can be "unsafe": > > > O_CLOEXEC must be used by default to not leak file descriptor > > > across exec(). > > > > > > Instead of macro get_unused_fd(), functions anon_inode_getfd() > > > or get_unused_fd_flags() should be used with flags given by userspace. > > > If not possible, flags should be set to O_CLOEXEC to provide userspace > > > with a default safe behavor. > > > > > > In a further patch, get_unused_fd() will be removed so that > > > new code start using anon_inode_getfd() or get_unused_fd_flags() > > > with correct flags. > > > > > > This patch replaces calls to get_unused_fd() with equivalent call to > > > get_unused_fd_flags(0) to preserve current behavor for existing code. > > > > > > The hard coded flag value (0) should be reviewed on a per-subsystem basis, > > > and, if possible, set to O_CLOEXEC. > > > > > > Signed-off-by: Yann Droneaud <[email protected]> > > > > Should I merge this (v5 on patchwork) or let Al do it ? > > > > Please merge it directly: patches from the previous patchsets were > picked individually by each subsystem maintainer after proper review > regarding setting close on exec flag by default. > > > Acked-by: Benjamin Herrenschmidt <[email protected]> > > > > Thanks a lot.
> Note: > latest patch (from v5 patchset) is at > http://lkml.kernel.org/r/fe27abcfab5563d36a3e5e58ff36e5500c39be6a.1388952061.git.ydrone...@opteya.com > v5 patchset is at > http://lkml.kernel.org/r/[email protected] > I have not yet seen the patch in your trees at https://git.kernel.org/cgit/linux/kernel/git/benh/powerpc.git/ I hope you would pick the patch, if possible in its latest version (unfortunately I'm not able to give the link to the astest patch in patchwork). Regards. -- Yann Droneaud OPTEYA -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
