On Mon, Jan 20, 2014 at 03:29:17PM +0530, Vinod Koul wrote: > On Fri, Dec 06, 2013 at 04:42:09PM +0100, Jonas Jensen wrote: > > vd->tx.cookie is set zero on dma_cookie_complete(), > > save to local before printing it. > > > > Signed-off-by: Jonas Jensen <jonas.jen...@gmail.com> > > --- > > > > Notes: > > dev_vdbg() could also be moved to happen earlier, what do you prefer? > This would be preferred IMHO. Also pls cc dmaengine@vger on this
I prefer this version - it means that the verbose debug printk doesn't impact the completion timing when printk is expensive (eg, because its outputting via a serial port.) -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit". -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
