From: Paul Bolle <pebo...@tiscali.nl> Date: Tue, 14 Jan 2014 20:46:52 +0100
> Building resource_tracker.o triggers a GCC warning: > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In function > 'mlx4_HW2SW_SRQ_wrapper': > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:3202:17: warning: > 'srq' may be used uninitialized in this function [-Wmaybe-uninitialized] > atomic_dec(&srq->mtt->ref_count); > ^ > > This is a false positive. But a cleanup of srq_res_start_move_to() can > help GCC here. The code currently uses a switch statement where a plain > if/else would do, since only two of the switch's four cases can ever > occur. Dropping that switch makes the warning go away. > > While we're at it, add some missing braces, and convert state to the > correct type. > > Signed-off-by: Paul Bolle <pebo...@tiscali.nl> Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
