On Wed, 2014-01-08 at 13:01 -0800, Muthu Kumar wrote: > On Wed, Jan 8, 2014 at 12:51 PM, Chris Mason <c...@fb.com> wrote: > > On Wed, 2014-01-08 at 12:40 -0800, Muthu Kumar wrote: > >> On Wed, Jan 8, 2014 at 12:16 PM, Chris Mason <c...@fb.com> wrote: > >> > On Wed, 2014-01-08 at 11:54 -0800, Muthu Kumar wrote: > >> >> Chris, > >> >> > >> >> [ 8.336061] WARNING: CPU: 0 PID: 0 at fs/bio.c:1778 > >> >> bio_endio+0xbe/0x100() > >> >> [ 8.336062] bio_endio: bio for (unknown) without endio > >> >> > >> >> This is my recent change to avoid memory leak in bio_endio. But I > >> >> think the problem is higher up, most likely bio_endio is called twice > >> >> on the same bio (which was freed before). > >> >> > >> > > >> > I think these are just two separate problems. Lets ignore the WARN_ON > >> > for now. > >> > > >> > >> Not really... the BUG that is triggered: > >> > >> kernel BUG at fs/bio.c:523! > >> > >> It is in bio_put() (added to bio_endio() as part of recent change) > >> which gets an already freed bio. > >> > > > > Oh! I see. Let me try with that one reverted. Thanks! > > > > -chris > > > > But, like I said, problem is in different place. I am running a "dd" > on ext4 fs for a while now, but didn't hit the problem. Any idea to > repro locally? I would also suggest running just the for-3.1/core to > isolate the issue.
Just reverting that change fixes it for me. Jens mentioned it was broken for on-stack bios. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
