> I don't really like it in general when we do > > #define MAYBE_CONST_LOOKING_THING (some_func()) > > I would almost rather see something like task_size(current) used.
I dont particularly like it, but it would be better for that to be a separate cleanup patch. I want to maximise my changes of this going in soon :) > > ===== include/linux/mm.h 1.212 vs edited ===== > > +++ edited/include/linux/mm.h 2005-01-26 01:20:12 +11:00 > > @@ -38,7 +38,7 @@ > > #include <asm/atomic.h> > > > > #ifndef MM_VM_SIZE > > -#define MM_VM_SIZE(mm) TASK_SIZE > > +#define MM_VM_SIZE(mm) ((TASK_SIZE + PGDIR_SIZE - 1) & PGDIR_MASK) > > #endif > > > > #define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n)) > ia64 asm/processor.h already has: > > #define DEFAULT_TASK_SIZE __IA64_UL_CONST(0xa000000000000000) > [...] > #define MM_VM_SIZE(mm) DEFAULT_TASK_SIZE > > So I think this will generate a warning there? Im confused. It does? Anton - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
