On 2013/12/23 16:59, Joe Perches wrote: > On Mon, 2013-12-23 at 09:46 +0100, Antonio Quartulli wrote: >> On 23/12/13 06:10, Ding Tianhong wrote: >> >> [...] >> >>> --- a/net/batman-adv/originator.c >>> +++ b/net/batman-adv/originator.c >>> @@ -41,7 +41,7 @@ int batadv_compare_orig(const struct hlist_node *node, >>> const void *data2) >>> const void *data1 = container_of(node, struct batadv_orig_node, >>> hash_entry); >>> >>> - return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0); >>> + return ether_addr_equal_unaligned(data1, data2) ? 1 : 0; >> >> ether_addr_equal_unaligned() returns a bool value which is implicitly >> converted to 1 or 0: there is no need for the ternary if anymore. > > Should these use batadv_compare_eth? > >
Yes, and need to remove the checks for return value. Regards Ding > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
