From: Fabio Estevam <fabio.este...@freescale.com>

Currently 'anatop_probe_end' path is executed on both succesfull and error paths
of anatop_regulator_probe().

To let the code a bit clearer, make 'anatop_probe_end' to be executed only when
an error happens.

Signed-off-by: Fabio Estevam <fabio.este...@freescale.com>
---
 drivers/regulator/anatop-regulator.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/anatop-regulator.c 
b/drivers/regulator/anatop-regulator.c
index c734d09..53e6048 100644
--- a/drivers/regulator/anatop-regulator.c
+++ b/drivers/regulator/anatop-regulator.c
@@ -210,9 +210,10 @@ static int anatop_regulator_probe(struct platform_device 
*pdev)
 
        platform_set_drvdata(pdev, rdev);
 
+       return 0;
+
 anatop_probe_end:
-       if (ret)
-               kfree(sreg->name);
+       kfree(sreg->name);
 
        return ret;
 }
-- 
1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to