On Fri, Dec 20, 2013 at 10:41 AM, Yoshihiro YUNOMAE <yoshihiro.yunomae...@hitachi.com> wrote: > Add dictionary information in structure cont. > Dictionary information is added when a driver uses structured printk, and the > information is shown in /dev/kmsg. Current kernel directly stores the > information to log_buf. This patch stores the dict information in structure > cont > first, then the information in cont is stored to log_buf. > > Signed-off-by: Yoshihiro YUNOMAE <yoshihiro.yunomae...@hitachi.com> > Cc: Kay Sievers <k...@vrfy.org> > Cc: Andrew Morton <a...@linux-foundation.org> > Cc: Joe Perches <j...@perches.com> > Cc: Tejun Heo <t...@kernel.org> > Cc: Frederic Weisbecker <fweis...@gmail.com> > Cc: linux-kernel@vger.kernel.org
This is wrong. Please do not apply. Racy ontinuation lines and strutured logging should not be mixed. Continuation lines are a nice kernel hack for debugging, useful to have, but cannot be trusted by userspace. The entire purpose of structured logging is to have trustable atomic logging messages, the both facilities should not be mixed. Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
