>>>>> Stephen C Tweedie (SCT) writes:
SCT> /*
SCT> * Be pessimistic here about the number of those free blocks which
SCT> * might be required for log descriptor control blocks.
SCT> */
SCT> ...
SCT> left -= (left >> 3);
oops. i overlooked this line. so, the fix becomes minor improvement patch ;)
thanks!
do you think the following can be improved?
/*
* @@@ AKPM: This seems rather over-defensive. We're giving commit
* a _lot_ of headroom: 1/4 of the journal plus the size of
* the committing transaction. Really, we only need to give it
* committing_transaction->t_outstanding_credits plus "enough" for
* the log control blocks.
* Also, this test is inconsitent with the matching one in
* journal_extend().
*/
if (__log_space_left(journal) < jbd_space_needed(journal)) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
