On 12/12/13 15:19, Ian Campbell wrote: > On Tue, 2013-12-03 at 15:40 +0000, Julien Grall wrote: >> On ARM (32 bits and 64 bits), the double-word is 8-bytes aligned. This will >> result on different structure from Xen and Linux repositories. >> >> As Linux is using __packed__ attribute, it must have a 4-bytes padding before >> each "id" field. >> >> This change breaks guest block support with older kernel. IMHO, it's >> acceptable >> because Xen on ARM is still on Tech Preview and the hypercall ABI is not yet >> freezed. >> >> Only one architecture (x86_32) doesn't have 64-bit ABI for the block >> interface. >> Don't add padding if Linux is compiled for this architecture. > > Konrad asked for confirmation that this didn't change x86.
I've also tested this using various combinations of kernels, and it seems to be perfectly fine, so: Acked-by: Roger Pau Monné <roger....@citrix.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
