Moin.
Attached patch fixes a problem of reading Video DVDs
through the cdrom_ioctl interface. VMware is among
the prominent victims.
The bug was introduced in kernel version 2.6.8 in the
function verify_command().
Regards,
Elias da Silva
--- linux-2.6.10/drivers/block/scsi_ioctl.c 2004-12-24 22:35:40.000000000 +0100
+++ linux-2.6.10-dvd/drivers/block/scsi_ioctl.c 2005-01-22 02:31:28.223951296 +0100
@@ -159,6 +159,11 @@
safe_for_read(GPCMD_SEEK),
safe_for_read(GPCMD_STOP_PLAY_SCAN),
+ /* Video DVD playback support */
+ safe_for_read(GPCMD_SET_STREAMING),
+ safe_for_read(GPCMD_SEND_KEY),
+ /* safe_for_read(0xe9), missing this opcode definition */
+
/* Basic writing commands */
safe_for_write(WRITE_6),
safe_for_write(WRITE_10),
@@ -179,13 +184,11 @@
safe_for_write(GPCMD_RESERVE_RZONE_TRACK),
safe_for_write(GPCMD_SEND_DVD_STRUCTURE),
safe_for_write(GPCMD_SEND_EVENT),
- safe_for_write(GPCMD_SEND_KEY),
safe_for_write(GPCMD_SEND_OPC),
safe_for_write(GPCMD_SEND_CUE_SHEET),
safe_for_write(GPCMD_SET_SPEED),
safe_for_write(GPCMD_PREVENT_ALLOW_MEDIUM_REMOVAL),
safe_for_write(GPCMD_LOAD_UNLOAD),
- safe_for_write(GPCMD_SET_STREAMING),
};
unsigned char type = cmd_type[cmd[0]];
@@ -194,13 +197,11 @@
return 0;
/* Write-safe commands just require a writable open.. */
- if (type & CMD_WRITE_SAFE) {
- if (file->f_mode & FMODE_WRITE)
- return 0;
- }
+ if ((type & CMD_WRITE_SAFE) && (file->f_mode & FMODE_WRITE))
+ return 0;
- if (!(type & CMD_WARNED)) {
- cmd_type[cmd[0]] = CMD_WARNED;
+ if (!type) {
+ type = cmd_type[cmd[0]] = CMD_WARNED;
printk(KERN_WARNING "scsi: unknown opcode 0x%02x\n", cmd[0]);
}
@@ -208,7 +209,14 @@
if (capable(CAP_SYS_RAWIO))
return 0;
- /* Otherwise fail it with an "Operation not permitted" */
+ if (!(type & CMD_WARNED))
+ {
+ cmd_type[cmd[0]] |= CMD_WARNED;
+ printk(KERN_WARNING "scsi: opcode 0x%02x write/rawio"
+ " permission denied\n", cmd[0]);
+ }
+
+ /* Otherwise fail it with an "Operation not permitted" */
return -EPERM;
}
