Hi Lee and Brian, I would also like to thank Brian; as always, very sensible comments.
I am tied up most of today and off work tomorrow (Christmas shopping!), but I will set aside Friday to go through the comments in detail. I should also have some time next week if necessary, subject to any panics that might arise! I also intend to respond to Huang's updated 'spi-nor' framework at the same time. At some stage, I would expect some of the device probing code in st_spi_fsm, particularly the configuration of read/write/erase operations based on capabilities, to be pulled into the 'spi-nor' framework. I do not see this an an obstacle to st_spi_fsm being integrated earlier though; it's presence in the kernel would provide another example of a H/W Controller that 'spi-nor' needs to accommodate. Cheers, Angus On 12/11/2013 08:48 AM, Lee Jones wrote: > Hi Brian, > > Thank you for taking the time to review, it's very much appreciated. > You bought out some interesting points that I'm happy to go away and > rectify. Firstly however, as I inherited this code I'd like to give > Angus a chance to comment before we go off on our own tangent and > rework some of the good code which perhaps should remain unchanged. > > Angus, do you have enough time to go through Brian's review comments > and perhaps reply to the ones that you feel would benefit from your > expert knowledge. To be frank, some of the questions that were asked I > wouldn't be able to answer without your guidance in any case. > > Thanks both. > > Kind regards, > Lee > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
