(2013/11/22 15:05), Namhyung Kim wrote: > Hi Oleg, > > On Wed, 20 Nov 2013 16:22:45 +0100, Oleg Nesterov wrote: >> On 11/18, Namhyung Kim wrote: >>> >>> -DEFINE_BASIC_PRINT_TYPE_FUNC(u8, "%x", unsigned int) >>> -DEFINE_BASIC_PRINT_TYPE_FUNC(u16, "%x", unsigned int) >>> -DEFINE_BASIC_PRINT_TYPE_FUNC(u32, "%lx", unsigned long) >>> +DEFINE_BASIC_PRINT_TYPE_FUNC(u8 , "%x", unsigned char) >>> +DEFINE_BASIC_PRINT_TYPE_FUNC(u16, "%x", unsigned short) >>> +DEFINE_BASIC_PRINT_TYPE_FUNC(u32, "%x", unsigned int) >>> +DEFINE_BASIC_PRINT_TYPE_FUNC(s8, "%d", signed char) >>> +DEFINE_BASIC_PRINT_TYPE_FUNC(s16, "%d", short) >>> +DEFINE_BASIC_PRINT_TYPE_FUNC(s32, "%d", int) >>> +#if BITS_PER_LONG == 32 >>> DEFINE_BASIC_PRINT_TYPE_FUNC(u64, "%llx", unsigned long long) >>> -DEFINE_BASIC_PRINT_TYPE_FUNC(s8, "%d", int) >>> -DEFINE_BASIC_PRINT_TYPE_FUNC(s16, "%d", int) >>> -DEFINE_BASIC_PRINT_TYPE_FUNC(s32, "%ld", long) >>> DEFINE_BASIC_PRINT_TYPE_FUNC(s64, "%lld", long long) >>> +#else /* BITS_PER_LONG == 64 */ >>> +DEFINE_BASIC_PRINT_TYPE_FUNC(u64, "%lx", unsigned long) >>> +DEFINE_BASIC_PRINT_TYPE_FUNC(s64, "%ld", long) >>> +#endif >> >> I must have missed something... Not only I do not understand why >> do we need "#if BITS_PER_LONG", I can't understand why >> DEFINE_BASIC_PRINT_TYPE_FUNC() needs "cast" argument. >> >> IOW, how about the patch below instead? > > Looks good to me. > > Masami, did you have any issue regarding the casts?
Hm, unless compiler doesn't complain about it,I'm OK for that. And as far as I tested on x86/x86-64/arm(32), this has no problem. :) Acked-by: Masami Hiramatsu <masami.hiramatsu...@hitachi.com> Thank you! -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu...@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
