On Tue, Nov 19, 2013 at 06:22:43AM -0800, Arjan van de Ven wrote: > >diff --git a/drivers/thermal/intel_powerclamp.c > >b/drivers/thermal/intel_powerclamp.c > >index 8f181b3f842b..e8275f2df9af 100644 > >--- a/drivers/thermal/intel_powerclamp.c > >+++ b/drivers/thermal/intel_powerclamp.c > >@@ -438,9 +438,7 @@ static int clamp_thread(void *arg) > > */ > > local_touch_nmi(); > > stop_critical_timings(); > >- __monitor((void *)¤t_thread_info()->flags, 0, 0); > >- cpu_relax(); /* allow HT sibling to run */ > >- __mwait(eax, ecx); > >+ mwait_idle_with_hints(eax, ecx); > > start_critical_timings(); > > atomic_inc(&idle_wakeup_counter); > > } > > > > hmm I take it that mwait_idle_with_hints is the one that also checks > need_resched() ? > if so... powerclamp may not want to use that (the whole point is to NOT give > the cpu > to tasks!)
That said, that drive is completely wrecked. It uses preempt_enable_no_resched() wrong too, it has uncommented barriers.. Dude, wtf are you guys smoking? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
