2013-11-15 14:00 keltezéssel, Geyslan Gregório Bem írta: > 2013/11/15 Caizhiyong <caizhiy...@hisilicon.com>: >> From: Cai Zhiyong <caizhiy...@huawei.com> >> Date: Mon, 11 Nov 2013 19:26:14 +0800 >> Subject: [PATCH] regmap: Fix 'ret' would return an uninitialized value >> >> This patch give a warning when calling regmap_register_patch with >> parameter num_regs <= 0. >> >> When the num_regs parameter is zero and krealloc doesn't fail, >> then the code would return an uninitialized value. However, >> calling this function with num_regs == 0, would be a waste as it >> essentially does nothing. >> >> Signed-off-by: Cai Zhiyong <caizhiy...@huawei.com> > Reviewed-by: Geyslan G. Bem <geys...@gmail.com> > > Seems a good approach. >
The patch doesn't apply. After manually applying this it threw a compilation error: drivers/base/regmap/regmap.c: In function ‘regmap_register_patch’: drivers/base/regmap/regmap.c:2176:6: error: expected expression before ‘)’ token Cai, You have missed the second parameter of WARN_ONCE(). Please append what you'd prefer to have outputten once the condition evaluates to true. -- Regards, Levente Kurusa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
