Hi Magnus, On Thursday 14 November 2013 11:03:06 Magnus Damm wrote: > On Thu, Nov 14, 2013 at 9:07 AM, Laurent Pinchart wrote: > > On Thursday 14 November 2013 07:59:36 Magnus Damm wrote: > >> From: Magnus Damm <d...@opensource.se> > >> > >> Set the ->irq_enable() and ->irq_disable() methods to NULL > >> to enable lazy disable of interrupts. > > > > Is that just for optimization purpose, or is there another reason ? > > It is needed for IRQCHIP_MASK_ON_SUSPEND operation, which in turn is > needed for Suspend-to-RAM. > > >> Also extend the code to set IRQCHIP_MASK_ON_SUSPEND which tells the core > >> that only IRQs marked as wakeups need to stay enabled during > >> Suspend-to-RAM. > > > > Shouldn't this be split to a separate patch ? > > I could split them up, but since there is a dependency and since I > mainly care about making sure Suspend-to-RAM works I preferred to keep > them together.
Fine with me. Could you then please update the commit message to mention that lazy disabling is required for IRQCHIP_MASK_ON_SUSPEND ? Same comment for patch 03/03. > >> Tested on the Lager board with GPIO-keys and Suspend-to-RAM. > >> > >> Signed-off-by: Magnus Damm <d...@opensource.se> > >> --- > >> > >> drivers/gpio/gpio-rcar.c | 3 +-- > >> 1 file changed, 1 insertion(+), 2 deletions(-) > >> > >> --- 0001/drivers/gpio/gpio-rcar.c > >> +++ work/drivers/gpio/gpio-rcar.c 2013-11-13 19:26:26.000000000 +0900 > >> @@ -368,10 +368,9 @@ static int gpio_rcar_probe(struct platfo > >> irq_chip->name = name; > >> irq_chip->irq_mask = gpio_rcar_irq_disable; > >> irq_chip->irq_unmask = gpio_rcar_irq_enable; > >> - irq_chip->irq_enable = gpio_rcar_irq_enable; > >> - irq_chip->irq_disable = gpio_rcar_irq_disable; > >> irq_chip->irq_set_type = gpio_rcar_irq_set_type; > >> irq_chip->flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_SET_TYPE_MASKED; > >> + irq_chip->flags |= IRQCHIP_MASK_ON_SUSPEND; > > > > You can write it as > > > > irq_chip->flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_SET_TYPE_MASKED > > | IRQCHIP_MASK_ON_SUSPEND; > > I know. =) If that's the preferred way then.. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
