Hi Ingo, On Mon, 11 Nov 2013 12:20:13 +0100, Ingo Molnar wrote: > * Namhyung Kim <namhy...@kernel.org> wrote: >> + /* >> + * It makes no sense to elide all of sort entries. >> + * Just revert them to show up again. >> + */ >> + list_for_each_entry(se, &hist_entry__sort_list, list) >> + if (!se->elide) >> + return; > > (Nit: please use curly braces around multi-line statements.)
Ah, okay. > >> + >> + list_for_each_entry(se, &hist_entry__sort_list, list) >> + se->elide = false; > > Looks good otherwise - this is the first step in the sort/key behavior > improvements that we talked about a few days ago, right? Right. And I'd like to wait bit more to hear other's opinion on this. > > Acked-by: Ingo Molnar <mi...@kernel.org> Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
