On Fri, Nov 08, 2013 at 06:53:29AM +0000, Caizhiyong wrote: > >> For further information, see "https://lkml.org/lkml/2013/8/6/550"; > > > > Thanks for doing this. Could we please get some acked-by's or, > > preferably, tested-by's from the MTD people? > > Acked-by: Ezequiel Garcia <ezequiel.gar...@free-electrons.com>
I don't remember acking this patch! Instead, I do remember asking for the test results, prooving the this change has _no_ change of behavior compared to the MTD parsing code: https://lkml.org/lkml/2013/10/25/164 Such results was never posted and unless we see those, I think I'd rather NACK this patch instead. I like the cleanup, but only if it's guaranteed to _not_ brake things, specially when dealing with a kernel parameter. -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
