On Fri, 2013-11-08 at 11:56 +1030, Rusty Russell wrote: > Joe Perches <j...@perches.com> writes: > > On Fri, 2013-11-08 at 09:41 +1030, Rusty Russell wrote: > >> Joe Perches <j...@perches.com> writes: > >> > That's a trust issue. > >> > I've done it. It isn't necessary. > >> > >> WTF? Now you just said it's not necessary, I *know* I can't trust you. > > > > "It" in this case is the grep that I did > > prior to sending the patch. > > Hi Joe,
Hi Rusty. > Apologies for my off tone. But I think we got tangled somewhere? > You said "It isn't necessary". > > You maintain that grepping the source to find out if you'd broken > something "isn't necessary"? > > git history shows me you've done lots of these cleanups. I'm pretty > sure that's not what you meant. Yeah, I think we did get a little crossed up there. No, grep and compiling changes are fundamentals before submitting trivial patches. What I meant was I had done the grep (and compile allyesconfig/allmodconfig of the files that use module_put_and_exit) before sending the patch. I don't think those are important details for a commit message. Dunno if you noticed that I attached the grep results in my 1st reply. Sometimes I do put details below the separator --- line after the signed-off-by. (I'll also admit I've sent patches without doing the appropriate checks and screwed them up. Lessons semi-learned) > But as maintainer, it's annoying that I had to check myself. I don't > have personal experience in how diligent you are. If you'd just > mentioned it, it would have saved me a few minutes and streamlined my > workflow immensely. > > Providing assurance makes me a happy maintainer. So I modified it > because it sets a clear example for others. > > I hope that clarifies, > Rusty. No worries. Unfamiliarity also does have its own set of issues. No problems on my side. Hope you don't any any this way either. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
