On Wed, Nov 6, 2013 at 6:17 AM, Borislav Petkov <b...@alien8.de> wrote: > I wonder if, at some point in the future - not now, necessarily, it'll > be prudent to add an error injection struct descriptor which contains > all those param* thingies and some of them could even be defined as a > union in it in order to make the whole code more readable. Like the > 'address' variable, for example, which is valid for multiple error > types... > > Just an idea though, so let me throw it out in the open.
That would indeed be a nice cleanup for later ... that many arguments to a function is tickling my threshold for "this ought to be simpler". Especially as we pass them all through einj_error_inject() on the way to __einj_error_inject(). Perhaps don't even need a new structure, just fill them into the existing set_error_type_with_address struct (which is the format they need to be in to pass to the BIOS). -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
