On Tue, Oct 22, 2013 at 08:12:51AM -0200, Geyslan Gregório Bem wrote: > 2013/10/21 Dave Chinner <da...@fromorbit.com>: > > On Mon, Oct 21, 2013 at 07:00:59PM -0500, Eric Sandeen wrote: > >> On 10/21/13 6:56 PM, Dave Chinner wrote: > >> > On Mon, Oct 21, 2013 at 06:18:49PM -0500, Ben Myers wrote: > > > > Yes, but to continue the Devil's Advocate argument, the purpose of > > debug code isn't to enlightent the casual reader or drive-by > > patchers - it's to make life easier for people who actually spend > > time debugging the code. And the people who need the debug code > > are expected to understand why an ASSERT is not necessary. :) > > > Dave, Eric and Ben, > > This was catched by coverity (CID 102348).
You should have put that in the patch description. Now I understand why there's been a sudden surge of irrelevant one line changes from random people that have never touched XFS before. <sigh> Ok, lets churn the code just to shut the stupid checker up. This doesn't fix a bug, it doesn't change behaviour, it just makes coverity happy. Convert it to the for loop plus ASSERT I mentioned in a previous message. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
