On Fri, 2013-10-18 at 19:35 +0200, Bartlomiej Zolnierkiewicz wrote:
> Make the driver DMA unmap also source buffers by itself
> (currently it DMA unmaps only destination buffers) as
> a preparation for introducing generic 'ummap' data.
>
> Cc: Dan Williams <d...@fb.com>
I think you may update Dan's address.
I assume you run exactly this module to test your DMA drivers.
If so, please take my
Acked-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
> Cc: Vinod Koul <vinod.k...@intel.com>
> Cc: Tomasz Figa <t.f...@samsung.com>
> Cc: Dave Jiang <dave.ji...@intel.com>
> Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com>
> ---
> drivers/dma/dmatest.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index 92f796c..f4a2a25 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -597,11 +597,10 @@ static int dmatest_func(void *data)
> set_user_nice(current, 10);
>
> /*
> - * src buffers are freed by the DMAEngine code with dma_unmap_single()
> - * dst buffers are freed by ourselves below
> + * src and dst buffers are freed by ourselves below
> */
> - flags = DMA_CTRL_ACK | DMA_PREP_INTERRUPT
> - | DMA_COMPL_SKIP_DEST_UNMAP | DMA_COMPL_SRC_UNMAP_SINGLE;
> + flags = DMA_CTRL_ACK | DMA_PREP_INTERRUPT |
> + DMA_COMPL_SKIP_SRC_UNMAP | DMA_COMPL_SKIP_DEST_UNMAP;
>
> while (!kthread_should_stop()
> && !(params->iterations && total_tests >= params->iterations)) {
> @@ -750,7 +749,8 @@ static int dmatest_func(void *data)
> continue;
> }
>
> - /* Unmap by myself (see DMA_COMPL_SKIP_DEST_UNMAP above) */
> + /* Unmap by myself */
> + unmap_src(dev->dev, dma_srcs, len, src_cnt);
> unmap_dst(dev->dev, dma_dsts, params->buf_size, dst_cnt);
>
> error_count = 0;
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
