On 10/16, Peter Zijlstra wrote:
>
> On Wed, Oct 16, 2013 at 10:43:48PM +0200, Oleg Nesterov wrote:
> > Peter, just in case. I understand that this all is minor. Just I am
> > confused. And in any case I do think we do not need __GFP_ZERO when
> > it comes to PAGE_SIZE allocation.
>
> Yeah; we could probably avoid it; if only the strcpy functions would
> return how many bytes they copied :/ Then we could create a nice little
> helper to \0 the tail end for alignment.
>
> Anyway, as long as the resulting code is obvious and makes it hard to
> leak something I'm fine.
OK. I'll wait for your review on this series, then send the next patch.
d_path() case can clear the extra bytes, everything else can use a single
if (name != buf)
name = str*copy(tmp, buf);
to avoid the leak.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
