On Fri, Oct 04, 2013 at 08:52:53PM -0400, Steven Rostedt wrote: > On Fri, 4 Oct 2013 14:39:46 -0700 > Andi Kleen <a...@firstfloor.org> wrote: > > > From: Andi Kleen <a...@linux.intel.com> > > > > UPROBES need the perf events code, so add a dependency > > from PERF_EVENTS to UPROBES. > > Can you please be a bit more specific on what uprobes requires of perf? > That is, what part of the perf events code is needed, and why?
Without this dependency, when UPROBE_EVENT is enabled and PERF_EVENTS disabled I first get warning: (UPROBE_EVENT) selects UPROBES which has unmet direct dependencies (UPROBE_EVENT && PERF_EVENTS) warning: (UPROBE_EVENT) selects UPROBES which has unmet direct dependencies (UPROBE_EVENT && PERF_EVENTS) and then later lots of errors like arch/x86/built-in.o: In function `do_notify_resume': /home/ak/lsrc/git/linux-2.6/arch/x86/kernel/signal.c:743: undefined reference to `uprobe_notify_resume' arch/x86/built-in.o: In function `arch_uprobe_exception_notify': /home/ak/lsrc/git/linux-2.6/arch/x86/kernel/uprobes.c:637: undefined reference to `uprobe_pre_sstep_notifier' /home/ak/lsrc/git/linux-2.6/arch/x86/kernel/uprobes.c:643: undefined reference to `uprobe_post_sstep_notifier' kernel/built-in.o: In function `mmput': /home/ak/lsrc/git/linux-2.6/kernel/fork.c:608: undefined reference to `uprobe_clear_state' I'm not fully sure why UPROBES has the && PERF_EVENTS; I didn't add that. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
