Hi, > From: Vivek Gautam [mailto:gautamvivek1...@gmail.com] > Sent: Friday, September 20, 2013 1:44 PM > > On Fri, Sep 20, 2013 at 5:11 PM, Vivek Gautam > <gautamvivek1...@gmail.com> wrote: > > On Wed, Sep 11, 2013 at 4:57 PM, Kamil Debski <k.deb...@samsung.com> > wrote: > >> Add a new driver for the Exynos USB PHY. The new driver uses the > >> generic PHY framework. > >> > >> Signed-off-by: Kamil Debski <k.deb...@samsung.com> > >> Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com> > >> Cc: Kishon Vijay Abraham I <kis...@ti.com> > >> Cc: Tomasz Figa <t.f...@samsung.com> > >> Cc: Sylwester Nawrocki <s.nawro...@samsung.com> > >> Cc: Marek Szyprowski <m.szyprow...@samsung.com> > >> --- > >> > >> Hi, > >> > >> This patch adds a new drive for USB PHYs for Samsung SoCs. The > driver > >> is using the Generic PHY Framework created by Kishon Vijay Abrahan I. > >> It can be found here https://lkml.org/lkml/2013/8/21/29. > >> This patch adds support to Exynos4 family of SoCs. Support for > >> Exynos3 and > >> Exynos5 is planned to be added in the near future. > >> > >> I welcome your comments. > > > > How do you plan to put support for exynos5 series. I can see you have > > made separate files for exynos4210 and 4212. > > Now for exynos5250 and above, we should be able to re-use some of the > > functions like "4212_rate_to_clk()" and "4212_iso()".
I see two options. One - moving the functions that could be reused to separate file. Two - exporting these functions in let's say 4212 and using them in 5250. What do you think? I will also support for S5PC110 in the Exynos 4210 file, as they are very similar. > > > > Let me know if i can help with something for exynos5 stuff. Now, I am trying to run the USB device on Exynos5. The board I am using is the Arndale board. Unfortunately I am having trouble as the USB lines from SoC are connected both to the device port and the USB/Ethernet chip (AX88796). Did you use the Arndale board when working with Exynos 5? > > > > Also please add linux-usb and linux-samsung mailing list too. I will. [snip] Best wishes, -- Kamil Debski Linux Kernel Developer Samsung R&D Institute Poland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
