On 09/23/2013 12:30 PM, Charles Keepax wrote: > Add device tree bindings for the pdata needed to configure the MICBIAS > generators.
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt > b/Documentation/devicetree/bindings/mfd/arizona.txt > + - wlf,micbias1 : Configuration for the micbias regulator, should include 5 > + cells. > + The first cell is the output voltage in millivolts > + The second cell a non-zero value indicates an external capacitor is > fitted I think you need some kind of delimiter (e.g. a colon) after "cell" there, to separate the line's label and description. > + The four cell a non-zero value indicates that the micbias should be s/four/fourth/ There are lots of cells here with a single-bit flag in them. Can the flags be combined into a single cell to reduce the DT size? cpp-based named constants should keep the *.dts file readable. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
