Dear Alexandre Pereira da Silva, > Hi, > > The commit > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/driv > ers/net/phy/micrel.c?id=b818d1a7f72575eef17e00dc4085512c9cc8897dbreaks > KSZ8051MNL phy > > Micrel gone wrong here. The PHY ID of KSZ8051 is the same as KSZ8031, even > the revision code matches. > > In my custom board, I cannot run these instructions or else my cpu will > lock up: > const u16 val = KSZPHY_OMSO_B_CAST_OFF | KSZPHY_OMSO_RMII_OVERRIDE; > phy_write(phydev, MII_KSZPHY_OMSO, val); > > This is a board property and not a phy one. Ideally, the phy should be > correctly strapped at the hardware level for the board in question, so no > changes in this registers should be needed. > > I think we could add a OF property to set these options, what do you think? > If that, I would also propose to convert the 50MHZ flag to OF as well. > > Other option is to handle this the same way as the 50MHZ flag, that is > being set by board code.
I wouldn't mind, but we should use something generic the other PHYs can use as well. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
