On Wed, Sep 18, 2013 at 10:39:42AM +0100, Jonathan Cameron wrote: > "Zubair Lutfullah :" <zubair.lutful...@gmail.com> wrote: > >On Tue, Sep 17, 2013 at 09:27:27PM -0700, Dmitry Torokhov wrote: > >> Hi Zubair, > >> > >> On Tue, Sep 17, 2013 at 09:44:07AM +0500, Zubair Lutfullah wrote: > >> > + > >> > + ret = devm_request_threaded_irq(indio_dev->dev.parent, > >> > + irq, > >> > + pollfunc_th, pollfunc_bh, > >> > + flags, indio_dev->name, > >> > + indio_dev); > >> > + if (ret) > >> > + goto error_kfifo_free; ... > >> > + > >> > +error_free_irq: > >> > + devm_free_irq(indio_dev->dev.parent, irq, indio_dev); > >> > >> What is the point of using devm_* here if you are doing explicit > >> management of the resource anyway (you explicitly release it in all > >> Dmitry > > The devm interfaces ensure this is all cleaned when the device is removed > thus avoiding the need to free the stuff explicitly. > Device will get freed on deliberate remove and on an error from probe. Hence > you can drop all calls to devm free. The devm free functions are only needed > if you wish to free in order to reallocate. This might happen if you want to > change a buffer size for instance. >
Thank-you for the feedback. Updated and resent the series. Zubair > -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
