>>> On 06.09.13 at 16:39, Konrad Rzeszutek Wilk <konrad.w...@oracle.com> wrote: > On Fri, Sep 06, 2013 at 03:06:02PM +0100, Jan Beulich wrote: >> >>> On 06.09.13 at 16:00, Konrad Rzeszutek Wilk <konrad.w...@oracle.com> >> >>> wrote: >> > We have already exported 'get_phys_to_machine' and there are >> > third-party drivers that depend on this other symbol. As such >> > lets make this balanced and also export this symbol. >> >> I tend to disagree: Allowing external modules read access to some >> internal state is quite different from also allowing them to alter it. > > I am not following you. We have drivers in the kernel that do > this now. For example xen-netfront uses set_phys_to_machine.
In which case exporting it would be fine (and necessary). But you explicitly said "third-party drivers". > Oddly it can be built as a module. I am wondering how it actually > works without this EXPORT symbol. See the early return in xennet_release_rx_bufs() - the use of the symbol is in dead code. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
