On Thu, Sep 05, 2013 at 02:51:01PM +0200, Ingo Molnar wrote: > > * Frederic Weisbecker <fweis...@gmail.com> wrote: > > > > Btw., a side note, append_chain() is a rather confusing function in > > > itself, with logic-inversion gems like: > > > > > > if (!found) > > > found = true; > > > > The check is pointless yeah, I'll remove that. > > Are you sure it can be removed as-is? It inverts the 'found' condition, > which then can be used later on AFAICS. (I haven't looked very deeply > though.)
Yeah in fact found is initialized to false. So the if (!found) is always true there. May be it's a leftover from past version that relied on gotos or so. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
