On Mon, Sep 02, 2013 at 05:36:03PM -0700, Josh Triplett wrote: > On Tue, Sep 03, 2013 at 08:26:21AM +0800, Shilong Wang wrote: > > 2013/9/3 Joe Perches <j...@perches.com>: > > > Wang Shilong <wangshilong1...@gmail.com> > > > sent me an automated checkpatch email I > > > thought was not useful. > > > > I am sorry if i give you any trouble, i have disabled it(in fact, it > > only has run for a day!) > > I would suggest that you leave it running, but rather than sending mails > directly, have it prep the mails for you to send after manual review. > Do some careful scrutiny for false positives and cases where the change > would not improve the code, and use checkpatch's options to turn off > the more contentious warnings (like the 80-column warning). Over time, > you'll develop a set of options that produce warnings people mostly > *want* to get notified about. Good suggestions! That's exactly what I'm trying to do. And Joe kindly showed me the initial list of checkpatch error types suitable for auto notification.
Coverage is good: the checkpatch robot iterates over every new commit in the 300+ git trees I collected over time. Some maintainer trees are skipped because they should already run the check. Here is the list of reports sent in the last two weeks. They are private emails directly sent to the commit author and committer. So far I've not received complaints on these unsolicited checkpatch reports. Aug 23 [netdev-next:master 200/301] WARNING: usb_free_urb(NULL) is safe this check is probably n Aug 23 [netdev-next:master 202/301] WARNING: usb_free_urb(NULL) is safe this check is probably n Aug 23 [linuxtv-media:master 321/499] ERROR: Unrecognized email address: 'Kyungmin Park <kyungmi Aug 23 [linuxtv-media:master 322/499] ERROR: Unrecognized email address: 'Kyungmin Park <kyungmi Aug 24 [xlnx:master-next 32/53] WARNING: unnecessary cast may hide bugs, see http://c-faq.com/ma Aug 28 [mmotm:master 473/483] WARNING: __func__ should be used instead of gcc specific __FUNCTIO Aug 28 [kvm:queue 13/14] ERROR: Unrecognized email address: 'Gleb Natapov @g...@redhat.com>' Aug 29 [dhowells-fs:keys-devel 9/12] WARNING: labels should not be indented Aug 29 [jolsa-perf:perf/plugins2 14/20] WARNING: storage class should be at the beginning of the Aug 30 [nfs:testing 47/61] ERROR: Unrecognized email address: 'Trond Myklebust <Trond.Myklebust@ Aug 31 [josef-btrfs:master 74/135] WARNING: kfree(NULL) is safe this check is probably not requi Aug 31 [jolsa-perf:perf/toggle6 6/8] WARNING: kfree(NULL) is safe this check is probably not req Sep 01 [jolsa-perf:perf/core_plugins 14/24] WARNING: storage class should be at the beginning of Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
