Hi Dmitry,
This patch looks fine, and applies ok. I'll send it off to Greg with a
couple more bug fixes shortly.
Sarah Sharp
On Tue, Aug 27, 2013 at 05:52:33PM +0300, Dmitry Kasatkin wrote:
> Used vim "=" as Sarah suggested.
>
> - Dmitry
>
> On Tue, Aug 27, 2013 at 5:47 PM, Dmitry Kasatkin <d.kasat...@samsung.com>
> wrote:
> > When debug is not enabled and dev_dbg() will expand to nothing,
> > log might be flooded with "callbacks suppressed". If it was not
> > done on purpose, better to use dev_dbg_ratelimited() instead.
> >
> > Signed-off-by: Dmitry Kasatkin <d.kasat...@samsung.com>
> > ---
> > drivers/usb/host/xhci-ring.c | 24 ++++++++----------------
> > 1 file changed, 8 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> > index 5b08cd8..3cbf1c0 100644
> > --- a/drivers/usb/host/xhci-ring.c
> > +++ b/drivers/usb/host/xhci-ring.c
> > @@ -3060,14 +3060,10 @@ int xhci_queue_intr_tx(struct xhci_hcd *xhci, gfp_t
> > mem_flags,
> > * to set the polling interval (once the API is added).
> > */
> > if (xhci_interval != ep_interval) {
> > - if (printk_ratelimit())
> > - dev_dbg(&urb->dev->dev, "Driver uses different
> > interval"
> > - " (%d microframe%s) than xHCI "
> > - "(%d microframe%s)\n",
> > - ep_interval,
> > - ep_interval == 1 ? "" : "s",
> > - xhci_interval,
> > - xhci_interval == 1 ? "" : "s");
> > + dev_dbg_ratelimited(&urb->dev->dev,
> > + "Driver uses different interval (%d
> > microframe%s) than xHCI (%d microframe%s)\n",
> > + ep_interval, ep_interval == 1 ? "" : "s",
> > + xhci_interval, xhci_interval == 1 ? "" :
> > "s");
> > urb->interval = xhci_interval;
> > /* Convert back to frames for LS/FS devices */
> > if (urb->dev->speed == USB_SPEED_LOW ||
> > @@ -3849,14 +3845,10 @@ int xhci_queue_isoc_tx_prepare(struct xhci_hcd
> > *xhci, gfp_t mem_flags,
> > * to set the polling interval (once the API is added).
> > */
> > if (xhci_interval != ep_interval) {
> > - if (printk_ratelimit())
> > - dev_dbg(&urb->dev->dev, "Driver uses different
> > interval"
> > - " (%d microframe%s) than xHCI "
> > - "(%d microframe%s)\n",
> > - ep_interval,
> > - ep_interval == 1 ? "" : "s",
> > - xhci_interval,
> > - xhci_interval == 1 ? "" : "s");
> > + dev_dbg_ratelimited(&urb->dev->dev,
> > + "Driver uses different interval (%d
> > microframe%s) than xHCI (%d microframe%s)\n",
> > + ep_interval, ep_interval == 1 ? "" : "s",
> > + xhci_interval, xhci_interval == 1 ? "" :
> > "s");
> > urb->interval = xhci_interval;
> > /* Convert back to frames for LS/FS devices */
> > if (urb->dev->speed == USB_SPEED_LOW ||
> > --
> > 1.8.1.2
> >
>
>
>
> --
> Thanks,
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
