On Tue, Aug 27, 2013 at 10:39:31AM +0800, Wanpeng Li wrote:
> The return value outside for loop is always zero which means madvise_hwpoison
> return success, however, this is not truth for soft_offline_page w/ failure
> return value.
I don't understand what you want to do for what reason. Could you clarify
those?
>
> Signed-off-by: Wanpeng Li <liw...@linux.vnet.ibm.com>
> ---
> mm/madvise.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/madvise.c b/mm/madvise.c
> index a20764c..19b71e4 100644
> --- a/mm/madvise.c
> +++ b/mm/madvise.c
> @@ -359,7 +359,7 @@ static int madvise_hwpoison(int bhv, unsigned long start,
> unsigned long end)
> page_to_pfn(p), start);
> ret = soft_offline_page(p, MF_COUNT_INCREASED);
> if (ret)
> - break;
> + return ret;
> continue;
> }
> pr_info("Injecting memory failure for page %#lx at %#lx\n",
This seems to introduce no behavioral change.
Thanks,
Naoya Horiguchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
